search

antonioribeiro / google2fa

A One Time Password Authentication package, compatible with Google Authenticator.
MIT License
1.83k stars 199 forks source link

Upgrade PHPStan to the latest version #185

Closed spaze closed 1 year ago

spaze commented 1 year ago

When running composer analyse, the old PHPStan throws a lot of "deprecated" errors on PHP 8.2, the upgrade fixes them.

Even PHPStan 0.12.100 itself says

⚠️  You're running a really old version of PHPStan.️

The last release in the 0.12.x series with new features
and bugfixes was released on September 12th 2021,
that's 513 days ago.

Since then more than 67 new PHPStan versions were released
with hundreds of new features, bugfixes, and other
quality of life improvements.

To learn about what you're missing out on, check out
this blog with articles about the latest major releases:
https://phpstan.org/blog

Upgrade today to PHPStan 1.8 or newer by using
"phpstan/phpstan": "^1.8" in your composer.json.
spaze commented 1 year ago

You're totally right. Added PHPStan to CI in #188 to make it more useful.

antonioribeiro commented 1 year ago

Hey @spaze, thanks for this PR. We just need you to sign your commits in order to approve it:

https://docs.github.com/articles/about-gpg/ https://dev.to/zahrakhadijha/git-fixing-unsigned-gpg-commits-phn

spaze commented 1 year ago

Hey, sorry missed the check. All commits now signed,thanks!