search

antonioribeiro / google2fa

A One Time Password Authentication package, compatible with Google Authenticator.
MIT License
1.83k stars 199 forks source link

Delete trailing comma from parameter list to support PHP 7 #200

Closed bio closed 3 days ago

bio commented 4 months ago

This PR resolves an issue with a trailing comma in the setSecret parameter list to support PHP 7.

Interghost commented 1 week ago

bump, can this be merged while we are waiting for bigger PRs that include the fix?

antonioribeiro commented 6 days ago

Hello @bio, you need to sign your commits in order for Github to allow them to be merged. Are you able to do this?

bio commented 6 days ago

@antonioribeiro sure, I've signed the commit

bio commented 6 days ago

@antonioribeiro github is still blocking the merge because the first commit is not signed, so I created a new PR #211.