Fixed the deprecated use of implode

antonioribeiro / health

Laravel Health Panel

BSD 3-Clause "New" or "Revised" License

1.94k stars 198 forks source link

Fixed the deprecated use of implode #178

Closed khoubeibouthour closed 4 years ago

khoubeibouthour commented 4 years ago

To avoid conflicts between versions using the glue as first param and deprecated versions using it as second, I suggest simply dropping the glue and let the function use the default.

robinflyhigh commented 4 years ago

@khoubeibouthour Can you please check the issue with https://github.styleci.io/analyses/QM0ylo

If all check passes then @antonioribeiro can merge the PR

khoubeibouthour commented 4 years ago

Sorry I had to close this PR because I removed the fork due to no response. I will be sending a new pull request from a new branch. Thanks for the update.