Closed vvanpo closed 4 years ago
Not being able to run the linter locally is kind of cumbersome, hence the 3 commit amends.
@antonioribeiro laravel/framework
version 7.22.2 is an important security patch, but this bug is preventing any project using pragmarx/health
from upgrading past 7.22.0.
The builds appear to be hanging on composer update
?
@vvanpo looks like there are some failed builds, can you rerun them
@ssmusoke I'm not sure I have permissions to do that. Sorry, I'm not very familiar with Travis-CI, but I can't seem to find any options that would let me rerun the build.
Thanks for this. Just fixed tests and tagged a new version. I just don't get why are we having a breaking change in Laravel in a minor version...
@antonioribeiro seems like it was tightening of type usages which lead to the break
Yeah, it's an unfortunate demonstration of Hyrum's Law.
Technically the documentation for Container::bind()
was always explicit in requiring a closure or a string: https://laravel.com/api/7.x/Illuminate/Contracts/Container/Container.html#method_bind
But the fact that passing an object worked just fine meant that people used it. The Laravel maintainers should have known this was going to break things downstream.
@antonioribeiro You tagged and released 0.10.2 which already existed from October 2019, the new version needs to be 0.10.3 and the new tag deleted too which may break deploys
It's odd because I didn't forced the tag push, but it still overrode it? Ok I just pushed the new 0.10.3 and deleted 0.10.2.
Awesome the tag now works
I think the issue was the capitalization of the v, one was capital the other was lower case so *nix style both were accepted
Laravel 7.22.0 (https://github.com/laravel/framework/releases/tag/v7.22.0) throws
TypeError
s when passed an object instead of a closure or class name.Fixes #183