search

antonioribeiro / health

Laravel Health Panel
BSD 3-Clause "New" or "Revised" License
1.94k stars 198 forks source link

Update phpunit/php-timer dependency to ^1.0|^2.0|^3.0|^4.0|^5.0 #204

Closed rohsyl closed 3 years ago

rohsyl commented 3 years ago

Hello,

I'm using your package in my project and have the following error when doing the composer require

image

Last release v0.10.3 is using the followings: "phpunit/php-timer": "^1.0|^2.0",

I saw that you already updateded it in master.

Master : "phpunit/php-timer": "^1.0|^2.0|^3.0|^4.0|^5.0",

Could you release that new version with the phpunit/php-timerdependency updated ?

Thanks a lot !

truesteps commented 3 years ago

Hey! I would like to bump this issue

truesteps commented 3 years ago

@rohsyl after a little bit of investigation, it seems that bumping the version isn't enough. I'm not sure whether you noticed, but in never versions of laravel, with never versions of php timer, the runtime of the health check always returns null making saving records into DB impossible, since it will result in the failure of all health checks. If you need to use the master release, just pust dev-master into the version in composer.json and composer will check out the master branch.

Keep in mind, runtime calculation will be broken until the implementation will be fixed, you can just update the health-check table, if you're saving health-check results into the db, to have the runtime column as nullable, and it will continue working.

But the maintainer of this package did well, not to release it, since it would break already existing implementations. Good work maintainer!

rohsyl commented 3 years ago

Thanks for your comment mate.

I already pulled the dev-master version to wait until the maintainer of the package fix it all.

antonioribeiro commented 3 years ago

Should be fixed now. Version 0.11.0 tagged.