search

antonioribeiro / ia-collection

Laravel Illuminate Agnostic Collection
MIT License
46 stars 23 forks source link

Chronos instead of Carbon #5

Closed ruudk closed 1 year ago

ruudk commented 4 years ago

See https://github.com/cakephp/chronos#differences-with-nesbotcarbon

Would you be open for a PR to replace Carbon with Chronos?

ruudk commented 4 years ago

Maybe I don't really understand why Carbon is a dependency for this library.

Is it really needed, or is it more like an optional support? I don't use Carbon, but I depend on a package that depends on a package that depends on this library and this library pulls in Carbon.

Now I suddenly have Carbon in my system and I don't want people to use it.

Can't we change Carbon to a dev dependency and only add the alias part when it's loaded?