antonioribeiro / sqli

A Laravel Artisan SQL Interactive Interface
BSD 3-Clause "New" or "Revised" License
60 stars 5 forks source link

Correção falta de dois pontos no arquivo json ("pragmarx/sqli" "0.*") da... #1

Closed angelorubin closed 10 years ago

angelorubin commented 10 years ago

... linha 169 do readme.php

Correção da falta de dois pontos entre as informações do json. Errado - "pragmarx/sqli" "0." Correto - "pragmarx/sqli":"0."

antonioribeiro commented 10 years ago

Composer accepts it with or without a colon, did you had trouble with that?

In my opinion

composer require "pragmarx/sqli" "0.*"

Is easier on the eyes than:

composer require "pragmarx/sqli":"0.*"

composer

angelorubin commented 10 years ago

Hello,

Certainly without the colon becomes simpler, but had trouble installing it on windows 7 through gitbash, just thought I'd be wondering collaborate more an oversight than a bug, did not want to question anything, for I have no knowledge to do it.

The error that occurred in this facility is here - http://s14.postimg.org/4d4xwf4wx/pragmarx_composer_update.png

It would not be because I use OS child (windows)? LOL

Even congratulations tool developed and if you want to discard the push knife him without hesitation.

2014-04-24 11:45 GMT-03:00 Antonio Carlos Ribeiro notifications@github.com :

Composer accepts it with or without a colon, did you had trouble with that?

In my opinion

composer require "pragmarx/sqli" "0.*"

Is easier on the eyes than:

composer require "pragmarx/sqli":"0.*"

[image: composer]https://cloud.githubusercontent.com/assets/3182864/2790726/fe972124-cbbe-11e3-9167-7851d9c052fd.png

— Reply to this email directly or view it on GitHubhttps://github.com/antonioribeiro/sqli/pull/1#issuecomment-41288548 .

antonioribeiro commented 10 years ago

You found a bug on Composer ;)

Just filed an issue: https://github.com/composer/composer/issues/2937.

Thanks for your support.

antonioribeiro commented 10 years ago

Angelo, Composer guys are trying to figure it out. Could you, please, do a test for them?

https://github.com/composer/composer/issues/2937#issuecomment-41305416

Execute:

php -r 'var_dump($_SERVER["argv"]);' -- "pragmarx/sqli" "0.*"

And tell them what you get.

angelorubin commented 10 years ago

Hi,

Following the test image - http://s26.postimg.org/jtwn280ex/pragmarx_composer_update_2.png

antonioribeiro commented 10 years ago

The result looks right and you should not have got that error, so how did you first try to install the package?

1) By editing composer.json and adding the line in the requirements and then executing composer update.

2) By executing composer require "pragmarx/sqli" "0.*" via command line.

angelorubin commented 10 years ago

Hi, Installed by option 1.

angelorubin commented 10 years ago

Hi, Installed by option 1.

2014-04-24 16:30 GMT-03:00 Antonio Carlos Ribeiro notifications@github.com :

The result looks right and you should not have got that error, so how did you first try to install the package?

1) By editing composer.json and adding the line in the requirements and then executing composer update.

2) By executing composer require "pragmarx/sqli" "0.*" via command line.

— Reply to this email directly or view it on GitHubhttps://github.com/antonioribeiro/sqli/pull/1#issuecomment-41321859 .

antonioribeiro commented 10 years ago

Yeah, that was the problem, if you have executed Composer in your command line:

C:\project\> composer require "pragmarx/sqli" "0.*"

You would not have that error, but you followed the common installation process which is to copy "pragmarx/sqli" "0.*" and paste in your composer.json file, in this case you really need to add the colon (:).

angelorubin commented 10 years ago

OK,

Problem solved, but either way would be cool this explanation in the README, because people normally follows this flow setup, I believe.

Thanks.

2014-04-25 10:41 GMT-03:00 Antonio Carlos Ribeiro notifications@github.com :

Yeah, that was the problem, if you have executed Composer in your command line:

C:\project> composer require "pragmarx/sqli" "0.*"

You would not have that error, but you followed the common installation process which is to copy "pragmarx/sqli" "0.*" and paste in your composer.json file, in this case you really need to add the colon (:).

— Reply to this email directly or view it on GitHubhttps://github.com/antonioribeiro/sqli/pull/1#issuecomment-41393486 .