search

antonioribeiro / support

Support Classes
BSD 3-Clause "New" or "Revised" License
59 stars 49 forks source link

Address #13 and drop laravel 4 compatibility #14

Closed fgreinus closed 7 years ago

fgreinus commented 7 years ago

Hey there,

i tried to come up with a solution for issue #13 .

The only clean way to do this (in my opinion) is to drop support for laravel 4.

I also refactored db_listen function to be able to remove the isLaravel53 function. Thing is, that when accessing Laravel::VERSION from within the package, the php artisan optimize command seem to bug. Maybe some double-loaded application stack due to the helpers file being loaded too early or so...

These changes fixed the problem.

BTW: Taylor's opinion on how to support different laravel versions https://twitter.com/taylorotwell/status/512050601115414528.

antonioribeiro commented 7 years ago

I think it's time to drop L4 support, but why would we change the vendor name? We can simply create separate branch to support 4.x.

fgreinus commented 7 years ago

Sorry, the changed vendor name was not intended for this PR. I'll put this into a separate branch