search

antonioribeiro / support

Support Classes
BSD 3-Clause "New" or "Revised" License
59 stars 49 forks source link

Not respecting APP_ENV in user's .env file? #8

Closed jesseleite closed 8 years ago

jesseleite commented 8 years ago

Curious why this package isn't respecting the user's APP_ENV setting in their .env file?

We have our environment set to APP_ENV=local, yet we noticed this when running our seeders:

screen shot 2016-04-05 at 2 11 56 pm

I investigated further, and it seems the setting is being overwritten by your package:

screen shot 2016-04-05 at 2 13 22 pm

If I disable your putenv() call here, then my APP_ENV setting is respected. The issue I see is that other packages and/or users may rely on that APP_ENV setting. Is there reason why it needs to be overridden by pragmarx/support?

jmfleming commented 8 years ago

This appears to have been resolved with the latest commit. Would it be possible to go ahead and tag this up a version?

jesseleite commented 8 years ago

@antonioribeiro, I pulled in dev-master and can verify that it fixes the APP_ENV override. Can you tag release and update composer.json for your pragmarx/firewall package please?

antonioribeiro commented 8 years ago

Doing it now.

antonioribeiro commented 8 years ago

Done.

Tagged support 0.6.6 firewall 1.0.1

jesseleite commented 8 years ago

Thank you!