search

antoniotuzzi / libyuv

Automatically exported from code.google.com/p/libyuv
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

ValidateJPeg crash #478

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Validate jpeg has been reported with logotech c9000 camera frames on linux.
C9000 has known framing errors.
Invalid frames will be passed to ValidateJPeg.  But it should gracefully fail.

Original issue reported on code.google.com by fbarch...@chromium.org on 27 Jul 2015 at 11:11

GoogleCodeExporter commented 8 years ago 
fixed by scanning from start of buffer.
consider followup that avoids ValidateJpeg call in jpeg decoder.  Have calling 
code run Validate.

Original comment by fbarch...@chromium.org on 7 Aug 2015 at 7:34

GoogleCodeExporter commented 8 years ago

Original comment by fbarch...@chromium.org on 14 Sep 2015 at 5:52

GoogleCodeExporter commented 8 years ago 
set LIBYUV_WIDTH=1280
set LIBYUV_HEIGHT=720
set LIBYUV_REPEAT=999
set LIBYUV_FLAGS=-1
out\release\libyuv_unittest --gtest_filter=*Valid*

On Win32

Was
libyuvTest.ValidateJpeg (3163 ms)
libyuvTest.ValidateJpegLarge (202 ms)

Now
libyuvTest.ValidateJpeg (7 ms)
libyuvTest.ValidateJpegLarge (247 ms)

Original comment by fbarch...@chromium.org on 14 Sep 2015 at 6:07

GoogleCodeExporter commented 8 years ago 
On OSX 32 bit
LIBYUV_WIDTH=640 LIBYUV_HEIGHT=360 LIBYUV_REPEAT=4000 
out/Release/libyuv_unittest --gtest_filter=*Valid*

Was
libyuvTest.ValidateJpeg (5581 ms)

Now
libyuvTest.ValidateJpeg (30 ms)

Original comment by phthor...@gmail.com on 14 Sep 2015 at 6:09

GoogleCodeExporter commented 8 years ago 
Fixed in r1483

Original comment by fbarch...@chromium.org on 14 Sep 2015 at 6:10