antoniy / mpv-youtube-dl-binding

94 stars 20 forks source link

Make compatible with multiprocess or rewrite to WebExtensions #40

Open GoodGuyNick opened 7 years ago

GoodGuyNick commented 7 years ago

Extension incompatible with Firefox multiprocess. You can check it using Add-on Compatibility Reporter. Update on Compatibility Milestones:

Firefox won’t run in multiprocess mode unless all enabled add-ons have the multiprocessCompatible flag set to true or are WebExtensions. This means that developers who haven’t set this flag don’t have to worry about multiprocess compatibility and can focus on WebExtensions and the Firefox 57 deadline.

utack commented 7 years ago

Seems to be working when you force it
https://wiki.mozilla.org/Electrolysis#Force_Enable
But I agree it would be nice to have it working for everyone who does not know about this or does not want to use this hack

skorokithakis commented 7 years ago

This extension makes my browsing ten times better, please don't let it die with FF 56, @antoniy.

monochrony commented 6 years ago

alternatively, you can drag urls out of links or the adressbar directly into MPV to make it work. holding shift while doing so even adds files to the playlist.

isn't as instantaneous, as you have to open the player first, but better than nothing.

dummys commented 6 years ago

I have a poc running right now, need to clean it a bit and I will send a pull request. Basically I use a python wrapper as a native app to call the selected player with subprocess.run().

GoodGuyNick commented 6 years ago

I think this project is dead so I've switched to Open With.

maxime-michel commented 6 years ago

Thanks for the tip @GoodGuyNick, there's no keyboard shortcut with that option though.

dummys commented 6 years ago

I pull requested one @ open_with github, checkit

On 24 Nov 2017 14:57, "Maxime Michel" notifications@github.com wrote:

Thanks for the tip @GoodGuyNick https://github.com/goodguynick, there's no keyboard shortcut with that option though.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/antoniy/mpv-youtube-dl-binding/issues/40#issuecomment-346834271, or mute the thread https://github.com/notifications/unsubscribe-auth/AB2fxacayrQddBv-iZD6cwhN9kUdkeWyks5s5stOgaJpZM4NOoZv .

maxime-michel commented 6 years ago

Yeah, I did see that. However, I'm switching to qutebrowser. It might not float everybody's boat, but as a Vimmer I like it. And that plugin is a one-liner with it:

config.bind(',m', 'spawn /usr/local/bin/mpv {url} --pause --keep-open')
woodruffw commented 6 years ago

A bit late to the party, but I created ff2mpv as a WebExtension clone for mpv-youtube-dl-binding. It provides the same context menu/toolbar interface as this plugin did, and nothing else.