search

antonkomarev / github-profile-views-counter

It counts how many times your GitHub profile has been viewed. Free cloud micro-service.
https://komarev.com/sources/github-profile-views-counter
MIT License
4.06k stars 369 forks source link

Feature: Abbreviating large numbers (> 1000) and applying appropriate suffixes #62

Closed Trkzi-Omar closed 11 months ago

Trkzi-Omar commented 1 year ago

The abbreviateNumber() function takes a numeric value as input and returns the abbreviated version of the number with an appropriate suffix. It is useful for displaying large numbers in a concise and easily understandable format.

antonkomarev commented 1 year ago

Cool idea! Thanks @Trkzi-Omar 🙏 Will try to find out time this weekend for review.

antonkomarev commented 1 year ago

@Trkzi-Omar will you resolve all issues or I should make it myself in other PR? Your changes will be authored by me then 🥲

Trkzi-Omar commented 1 year ago

@antonkomarev

I apologize for being unable to proceed with the PR, I was quite busy these past few months (will probably still be for another month or two), and haven't had time to contribute to OSS.

If you think that it would be better for the community, then feel free to author changes in a new PR. I would totally understand :D

antonkomarev commented 1 year ago

@Trkzi-Omar I can wait, I'm not in a hurry.

antonkomarev commented 11 months ago

@Trkzi-Omar any progress with it?

Trkzi-Omar commented 11 months ago

@Trkzi-Omar any progress with it?

I actually forgot about this one. I will make a new PR tonight.