antonmedv / fx

Terminal JSON viewer & processor
https://fx.wtf
MIT License
19.08k stars 438 forks source link

No colors within tmux over ssh #259

Closed idvorkin closed 1 year ago

idvorkin commented 1 year ago

FX is awesome, (and I love TMUX :) ).

(Dup of #206, but I can't reopen that)

Is there a plan to fix? I'm also happy to debug!

TL;DR to resolve

export COLORTERM=truecolor
antonmedv commented 1 year ago

Will try to reproduce the bug. Can you try to update charm libs and see in it fixes the issue?

antonmedv commented 1 year ago

@idvorkin BTW do you use reducers with fx? (fx .foo .bar '.map(x=>x)`) And do you have nodejs installed on your machine?

idvorkin commented 1 year ago

@antonmedv - Thanks for the quick response!

I don't use reducers, but just tried them. Doesn't seem to change anything. I don't think I have charm installed. I tried installing it, nothing changed. I do have node installed.

Happy to try anything that can help!

Here's some info on my system:

ec2-user in 🌐 shell in nlp on  main [$!?⇡] via  v18.10.0 via 🐍 v3.10.7
❯ export | grep TERM
TERM=tmux
TERM_PROGRAM=tmux
TERM_PROGRAM_VERSION=3.3a

ec2-user in 🌐 shell in nlp on  main [$!?⇡] via  v18.10.0 via 🐍 v3.10.7
❮ node --version
v18.10.0

ec2-user in 🌐 shell in nlp on  main [$!?⇡] via  v18.10.0 via 🐍 v3.10.7
❮ npm ls -g
/home/linuxbrew/.linuxbrew/lib
├── fkill-cli@7.1.0
├── git-stats@3.1.1
├── npm@8.19.2
└── prettier@2.8.4

ec2-user in 🌐 shell in nlp on  main [$!?⇡] via  v18.10.0 via 🐍 v3.10.7
❯ npm ls -g  --all | grep charm
idvorkin commented 1 year ago

One thing to mention, it happens when I'm running tmux in an ssh session, not if I'm running tmux natively on my mac.

(However, every other app does colors correctly)

idvorkin commented 1 year ago

Bump

idvorkin commented 1 year ago

@antonmedv. Saw that message was going to yell at who wrote it. Hahaha.

antonmedv commented 1 year ago

=)))

antonmedv commented 1 year ago

I'm actually in full rewrite of fx right now)). But now stuck at https://github.com/antonmedv/expr for a while.

idvorkin commented 1 year ago

You get to work on some cool stuff!! Excited for fx v.Next.

Out of curiosity, does google let you do this as your day job?

antonmedv commented 1 year ago

Nope) 👎

In fact I got laid off a few months back (with 12k others) from Google.

Now just working on my open source project and thinking if I can turn one of them into a business.

idvorkin commented 1 year ago

:(

On Sun, Sep 3, 2023 at 9:32 AM Anton Medvedev @.***> wrote:

Nope) 👎

In fact I got laid off a few months back (with 12k others) from Google.

Now just working on my open source project and thinking if I can turn one of them into a business.

— Reply to this email directly, view it on GitHub https://github.com/antonmedv/fx/issues/259#issuecomment-1704347881, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACETFJIMEGJMOVXRBGK75TXYSWINANCNFSM6AAAAAA3WWSOPU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

antonmedv commented 1 year ago

I've refactored fx from the ground up and also updated all deps. Please check out if it works in master.

idvorkin commented 1 year ago

Nope, still doesn't work. Also, assuming you know, but no longer does folding by default. How can I help debug?

antonmedv commented 1 year ago

no longer does folding by default.

Yes. I'm thinking about making it the default behavior.

idvorkin commented 1 year ago

Makes sense. my last comment was ambiguous.

I'm happy to help debug the color issues. Just tell me what to do.

antonmedv commented 1 year ago

It is something in bubbletea code. Maybe some bug in detecting tmux?

idvorkin commented 1 year ago

To clarify it's tmux over ssh, updated issue title

idvorkin commented 1 year ago

Yup, repro'd with bubble tea directly:

https://github.com/charmbracelet/bubbletea/issues/825

antonmedv commented 1 year ago

Looks like upstream issue is closed.