search

antonmedv / fx

Terminal JSON viewer & processor
https://fx.wtf
MIT License
19.07k stars 438 forks source link

refactor: reorganize models #282

Closed hedhyw closed 7 months ago

hedhyw commented 1 year ago

Rebase of #257

Move model to an exportable package.

It doesn't make the struct model exportable (to reduce changes).

Local manua test: echo '{"test": [1, 2, 3]}' | go run *.go image

antonmedv commented 1 year ago

Such a big PR) Will try to review it.

lpoirothattermann commented 9 months ago

@antonmedv can you review the PR and merge it ?

antonmedv commented 9 months ago

This is quite a big PR. Will try to find sometime....

hedhyw commented 7 months ago

@antonmedv should I rebase it? or not the best time?

antonmedv commented 7 months ago

I decided not to support exportable package at this point. Sorry.

hedhyw commented 6 months ago

@antonmedv what do you think about changing your decision?

antonmedv commented 6 months ago

Oh, I see. You do use fx as a module in your app.

hedhyw commented 6 months ago

Oh, I see. You do use fx as a module in your app.

Yes! Is it OK if I create a new PR with the same change? This is a big change, but it only involves simple "moves" of files.