antonmedv / walk

Terminal file manager
MIT License
3.22k stars 89 forks source link

feat: icons support #67

Closed dlvhdr closed 1 year ago

dlvhdr commented 1 year ago

https://user-images.githubusercontent.com/6196971/215571496-d678b9ef-d2ad-4b72-99a3-8675adaa55ec.mov

antonmedv commented 1 year ago

Awesome! What about adding this support via env LLAMA_ICONS=true instead on --icons?

dlvhdr commented 1 year ago

I was thinking of adding a couple more flags in the future like:

These flags come from exa and are really useful for me.

If you like these additional flags, having an env variable will not scale IMHO. wdyt?

antonmedv commented 1 year ago

But with flags you can put them in .bashrc and now llama works with such config?) We already have LLAMA_EDITOR.

dlvhdr commented 1 year ago

I use the ll alias so cd works, so I can just pass there all the flags. Other people can also add such flags under an alias. If you prefer env variables I can do that but flags seems cleaner to me.

antonmedv commented 1 year ago

I use the ll alias so cd works, so I can just pass there all the flags.

Make sense.

Flags are okay :)

antonmedv commented 1 year ago

BTW, will you be able to generate gif the same way as in https://github.com/antonmedv/llama/tree/master/.github/images ? Using vhs.

dlvhdr commented 1 year ago

Yeah vhs is awesome

dlvhdr commented 1 year ago

Cool, so if you're good with the PR feel free to merge :)

antonmedv commented 1 year ago

Can you also generate the gif?

dlvhdr commented 1 year ago

@antonmedv done!

antonmedv commented 1 year ago

Awesome thanks! Let’s also add this gif in examples in README with instructions on how to install icons.

dlvhdr commented 1 year ago

Done :) Let me know if that's ok