search

antonmi / espec

Elixir Behaviour Driven Development
Other
808 stars 62 forks source link

Task.async_stream for async examples? #270

Closed jfornoff closed 6 years ago

jfornoff commented 6 years ago

Hi there,

I've been trying to get to the bottom of an issue that we've encountered (Postgres sandboxed connections being attempted to be checked out during before, before being checked back in during finally)

As I was reading through SuiteRunner I was wondering whether it's possible to utilize Task.async_stream since it pretty much seems like what is done with run_async.

I'd be happy to provide a PR if you don't see any roadblocks with that. Best, Jan

antonmi commented 6 years ago

Hi, Jan! PR is welcomed if it makes ESpec even better!)

jfornoff commented 6 years ago

Implementing this is straightforward, but there is some weirdness around shared specs that I haven't quite tracked down yet.

jfornoff commented 6 years ago

When we resolve #279, this should be super straightforward :-)

antonmi commented 6 years ago

Hi, @jfornoff ! Thanks for PR. I've noticed that tests run much faster with this Task.async_stream. ESpec 1.6.3 version includes the changes.

jfornoff commented 6 years ago

Yay! :-)