Let evaluation in shared specs not working correctly

antonmi / espec

Elixir Behaviour Driven Development

Other

808 stars 62 forks source link

Let evaluation in shared specs not working correctly #279

Closed jfornoff closed 5 years ago

jfornoff commented 6 years ago

Hi there!

I've finally pinpointed the issue that I've been seeing with shared specs. Reproducing repo: https://github.com/jfornoff/sharedspec

If you let_overridable multiple lets from the outer context in a shared spec, the let does not seem to cache properly, not sure what the exact cause of this is though.

You can just run mix espec in the repo and see the spec/reproduction_spec.exs for an example where the expected behavior differs from the actual behavior.

antonmi commented 6 years ago

Thank, @jfornoff ! Will take a look.

antonmi commented 5 years ago

Hi, @jfornoff ! Thanks for the issue! This is fixed in 1.6.2. Please, check!

jfornoff commented 5 years ago

Hey thanks @antonmi! Looks great, will check tomorrow on the bigger testsuite, but it sure fixed the issues I had working on #270 :-)

WIll shoot you a quick PR on that for discussion on that!