Start every test in a new process, watch for it's death

antonmi / espec

Elixir Behaviour Driven Development

Other

808 stars 62 forks source link

Start every test in a new process, watch for it's death #285

Closed Kukunin closed 5 years ago

Kukunin commented 5 years ago

Fixes #283, where the whole suite might crash on a single test

Kukunin commented 5 years ago

Wait with merging, I'm testing it on my pet project, and I might add more commits

Kukunin commented 5 years ago

I checked with ex_unit - they are fault tolerant to process exits as well as they run every example in a separate PID. I'm not sure whether my change affects Ecto.Sandbox, since even async: false examples run in different PIDs.

Kukunin commented 5 years ago

I roll enough this PR with my project and can't see any downside:

ecto isn't sensitive for this change
it handles when a test dies well

Please, review it and merge, if you like it

antonmi commented 5 years ago

Thanks @Kukunin ! It looks awesome! Sorry for late response.

Kukunin commented 5 years ago

Later is better, than never =) Thanks

antonmi commented 5 years ago

@Kukunin , I've just published 1.6.4 with the changes.