Add support for Phoenix channels

antonmi / espec_phoenix

ESpec for Phoenix web framework.

MIT License

137 stars 33 forks source link

Add support for Phoenix channels #17

Closed vitalis closed 8 years ago

vitalis commented 8 years ago

It will be nice to have support for phoenix channels, @antonmi I can try to issue pull request if you need help

antonmi commented 8 years ago

Hi Vitaly! Yes, sure! Pull requests are welcomed! Don't forget add related functionality and specs to test_app

antonmi commented 8 years ago

It would be perfect to implement a chat in test_app. You can follow this approach: Phoenix_chat_example

col commented 8 years ago

:+1:

col commented 8 years ago

@vitalis - Have you started on a pull request for this?

brain-geek commented 8 years ago

Channel specs can already be implemented using existing ESpec code, but it's a bit messy. I've posted working implementation here.

If there are suggestions how to change the example, that would be awesome.

vitalis commented 8 years ago

@col I'm working on it, will issue a pull request in a few days

antonmi commented 8 years ago

Please, look at 0.6.0.

vitalis commented 8 years ago

@antonmi Cool! Thank you for adding channels support. I see that from version 0.5.0 you removed requests specs support, any specific reason for it? We have a lot of requests specs and now I don't have a way to upgrade from 0.3.0 to 0.6.0 ...

antonmi commented 8 years ago

Hi, @vitalis ! According to phoenix conventions, controllers specs plays that role. Please, take a look at examples in 'rumbrella' project.

vitalis commented 8 years ago

Tnx @antonmi, updated my specs to controller specs, everything works great, thank you for the amazing contribution to elixir community!!!!

antonmi commented 8 years ago

Thanks for using ESpec