search

antonmi / espec_phoenix

ESpec for Phoenix web framework.
MIT License
138 stars 33 forks source link

Fix interactions with Phoenix 1.2 and Ecto 2.0 #28

Closed diogobeda closed 8 years ago

diogobeda commented 8 years ago

Fixes #27 and #16, but introduces breaking changes. Because of it, I versioned it as 1.0.0, but I'd like to hear your opinions on the best approach.

\cc @antonmi

antonmi commented 8 years ago

Hi, Diogo! Thanks for PR! Let's make the version 0.3.0. We can add warning about breaking changes to Readme

diogobeda commented 8 years ago

Great @antonmi, gonna do it later today. Also will remove elixir 1.1 from .travis.yml as you commented on #26

brain-geek commented 8 years ago

@diogobeda Then I'm waiting for your changes to rebase my PR. Because to make mine pass, I need your changes on version updates for phoenix.

diogobeda commented 8 years ago

@antonmi I'm kinda insecure on making it 0.3. According to semver, we'd have to increase the major version when introducing incompatible changes. And with my PR, phoenix_ecto will just support phoenix >= 1.2 cause we're using a function that didn't exist on previous versions.

If you're not comfortable on putting out a 1.0 release now and want to add more features to the release, we can create an alpha or rc release to wait for those features. What do you think? It'd not be fair to the lib users to get breaking changes on a minor version.

antonmi commented 8 years ago

@diogobeda ESpecPhoenix is still in the early stage of development. The concept of the library might change in the near future. So I think 0.3.0 is enough. Thanks!

diogobeda commented 8 years ago

Okay, then @antonmi. Thanks for the feedback and sorry about the delay, I was just trying to bring up the discussion. If the build passes I think we're good to merge.

antonmi commented 8 years ago

Thanks, @diogobeda! Please remove the last commit, it breaks the build.

antonmi commented 8 years ago

Thanks, guys!