search

antonmi / espec_phoenix

ESpec for Phoenix web framework.
MIT License
137 stars 33 forks source link

Obsolete ecto dependency in some cases? #36

Closed brain-geek closed 7 years ago

brain-geek commented 7 years ago

Hey

Right now I have Phoenix app without Ecto. But installing espec_phoenix still makes ecto required dependency. Is it possible to make this dependency optional somehow?

antonmi commented 7 years ago

Hi, Alex! Seems like both phoenix and echo dependencies can be dev only. Will check tomorrow

brain-geek commented 7 years ago

As for Phoenix - the project is espec_phoenix, so dependency on Phoenix is understandable. But removing Ecto dependency could be beneficial.

antonmi commented 7 years ago

@brain-geek I've released 0.6.2 which has only espec dependency.

joshrieken commented 7 years ago

@antonmi I think phoenix must remain a dependency because of the use of Mix.Phoenix, Phoenix.ConnTest, etc.. Please correct me if I am wrong.

antonmi commented 7 years ago

@facto , you are right! Thanks!

antonmi commented 7 years ago

I've returned the dependency in 0.6.4