antonmi / espec_phoenix

ESpec for Phoenix web framework.
MIT License
137 stars 33 forks source link

Support for phoenix 1.3 #48

Open StefanWallin opened 7 years ago

StefanWallin commented 7 years ago

Are you currently working on 1.3-support for the upcoming release? I tried manipulating version locks and got plain specs working, but if I try to use controller-specs or request-specs we get issues about ... Myapp.Router.Helpers is not loaded....

Opened issue for discussion and as a question. I'm quite new to the community from the Rails community and was recommended to start looking into 1.3, but it seems there are a lot of packages that don't support it yet.

antonmi commented 7 years ago

Thanks @StefanWallin ! Will take a look!

antonmi commented 7 years ago

Hi, @StefanWallin ! Sorry, for the late response. Please teke a look at: https://gist.github.com/chrismccord/71ab10d433c98b714b75c886eff17357 Seems like you need to add Web namespace to the helpers.

antonmi commented 7 years ago

I'll do the changes in espec_phoenix when 1.3 stable version released

StefanWallin commented 7 years ago

Awesome stuff! Will try it out later! Thanks for the help