search

antonmi / espec_phoenix

ESpec for Phoenix web framework.
MIT License
137 stars 33 forks source link

Renaming the `model` attribute ? #64

Open dennym opened 2 years ago

dennym commented 2 years ago

Heyhey

I'm pretty sure that the model attribute either comes from the ruby world or the old days when phoenix tried to be more like ruby on rails and had models. Wouldn't it to make sense to rename that attribute to schema since its basically just testing the schema and the changesets of it?

Just wondering why it did not happened yet or if there is a specific reason you stuck with the model.

If there is interest for it I surely can provide a pull request for it.

best Denny

antonmi commented 1 year ago

Hey Denny! You are right, "model" is a ruby legacy :) Feel free to provide PR.