antonpup / Aurora

Unified lighting effects across multiple brands and various games.
http://www.project-aurora.com/
MIT License
1.82k stars 368 forks source link

Cooler Master MK750 Support Request #1014

Closed MithicalM closed 6 years ago

MithicalM commented 6 years ago

What are you experiencing an issue with?

What is the version of Aurora you are experiencing this issue with?

My version is... beta v0.61-dev4

simon-wh commented 6 years ago

~I don't see the MK750 mentioned anywhere in the CM SDK, so I'm not sure if it is supported, but it seems like it should be. Does it work when you select a similar layout? Just not properly working with the additional lights it has available?~

EDIT:

Just found some reddit posts indicating that an SDK for the MK750 hasn't been released yet and that it should be released soon (They say it should be coming by the week after which is about 10 days ago)

https://www.reddit.com/r/coolermaster/comments/7y97f6/release_date_for_mk750_sdk/ https://www.reddit.com/r/coolermaster/comments/7yrh9q/what_happened_to_sdk_for_the_mk750/

So there isn't much that can be done to support it currently, but I'll leave this open as it seems like it'll be able to be implemented soon.

MithicalM commented 6 years ago

I just went on the product page and clicked on download and there is a SDK available with a document which mentions the MK750. I am not 100% if it is the right think or not but I thought I would let you know! http://www.coolermaster.com/peripheral/keyboards/masterkeys-mk750/

MithicalM commented 6 years ago

@simon-wh Were you able to check and see if that SDK I mentioned in my last comment is the right thing at all?

simon-wh commented 6 years ago

It looks right, it seems to just be an updated version of the current cm sdk. I'll try and see if I can just update the sdk and hopefully, that'll get the core of it working.

MithicalM commented 6 years ago

Awesome! I hope it works too! Thanks for your work :)

simon-wh commented 6 years ago

@MithicalM Could you try to use the build of the commit above? Found here. That is only updating the SDK to the latest which should allow for basic support of the MK750 (i.e. just the normal parts of the keyboard, not any of the additional lights on the side yet). I've also made some optimisations to the CM integration after updating the SDK which hopefully works, if you could test this build as well, it'd be helpful. Ideally, both should work the same

MithicalM commented 6 years ago

@simon-wh I am at uni atm but I downloaded and gave it a quick look and I can't see the MK750 under Devices & Wrappers as a preferred device. But I will give it a shot within the next hour.

simon-wh commented 6 years ago

@MithicalM I haven't added a layout for the MK750, so you won't see it as an option. Just try using it with one that has a stock layout.

MithicalM commented 6 years ago

@simon-wh okay so it works perfectly fine on Aurora-v0.6.1-dev4-296 but when I go to use Aurora-v0.6.1-dev4-297 (the optimized one) it doesn't work at all. It recognizes the keyboard but none of the lighting effects work on 297. On 296 I have to choose Masterkeys Pro L for the lighting effects to start working. But that does nothing on 297.

simon-wh commented 6 years ago

Okay, I think I'll revert the commit for 297 and leave it as it is for now as I can't really test it myself.

On Thu, 15 Mar 2018, 16:34 Mithusan Muthulingam, notifications@github.com wrote:

@simon-wh https://github.com/simon-wh okay so it works perfectly fine on Aurora-v0.6.1-dev4-296 but when I go to use Aurora-v0.6.1-dev4-297 (the optimized one) it doesn't work at all. It recognizes the keyboard but none of the lighting effects work on 297.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/antonpup/Aurora/issues/1014#issuecomment-373440470, or mute the thread https://github.com/notifications/unsubscribe-auth/AKTCCDWbNDGRdi7847IBIRTHnXddmsp4ks5tepgtgaJpZM4SiHEC .

MithicalM commented 6 years ago

I just noticed another bug where for DotA the keyboard lights up light this (https://i.imgur.com/AUfQHvl.jpg) when it light up like this (https://i.imgur.com/95G0vD7.png).

MithicalM commented 6 years ago

Okay so it is the same for all games. It seems to be lighting all keys 1 off to the left.

simon-wh commented 6 years ago

I think I have a pretty good idea why that is happening, which may also explain why there were so many issues with the Num 4,5,6 on the Pro L keyboard. I'll try and implement a fix for it later when I'm able to work on this.

MithicalM commented 6 years ago

Sorry misclicked and closed the issue.

simon-wh commented 6 years ago

My theory turned out to not be the case. I've reverted the "optimisations" and made some changes which, I don't think will solve your issue, but should make sure that the other keyboards still work properly. If you could test it out, it'd be great, you can find it here.

MithicalM commented 6 years ago

@simon-wh I think there is a bug or something with the build as I am getting this "The build job does not contain any artifacts." and under console it says "Command exited with code 1"

simon-wh commented 6 years ago

Yeah, it seems appveyor seems to be having issues building that commit, I didn't have any issues building it on my end, trying to sort it out right now.

simon-wh commented 6 years ago

@MithicalM Try this I had to update the build version appveyor was using.

MithicalM commented 6 years ago

@simon-wh 302 isn't work for my keyboard at all. It is doing the same thing as 297 did. Same goes for 303. All my lights are off but my keyboard is getting detected under Device Manager of Aurora

simon-wh commented 6 years ago

@MithicalM Could you test this build? Doing some debugging of why it isn't working. Could you also check if you're getting any errors in your log?

MithicalM commented 6 years ago

I just checked my logs folder and I have a log file from yesterday which is almost 30 GB big for some reason and I can't open it with notepad.exe or notepad++. The build you linked me from dropbox works again but the lights are misaligned like previously. This is the log file from running it for a couple seconds with the build you sent me from dropbox

simon-wh commented 6 years ago

It appears the error you're getting a lot is caused by the AtmoOrb device, disable it in settings to make that error go away

On Fri, Mar 16, 2018 at 9:22 PM, Mithusan Muthulingam < notifications@github.com> wrote:

I just checked my logs folder and I have a log file from yesterday which is almost 30 GB big for some reason and I can't open it with notepad.exe or notepad++. The build you linked me from dropbox works again but the lights are misaligned like previously. This is the log file https://www.dropbox.com/s/uywg74n393k4kiz/2018-03-16%2021.17.41.log?dl=0 from running it for a couple seconds with the build you sent me from dropbox

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/antonpup/Aurora/issues/1014#issuecomment-373848559, or mute the thread https://github.com/notifications/unsubscribe-auth/AKTCCEDbqbfZ9rfS7ms9KP4TE0tWdPeNks5tfC0IgaJpZM4SiHEC .

MithicalM commented 6 years ago

@simon-wh Uhhh it already is off under device manager. image

MithicalM commented 6 years ago

I noticed another thing where the bottom 2 rows of the keyboard, none of the LEDs work on those areas at all. Not sure if it is a bug or a feature which I can change. Edit: Tagged Image image

MithicalM commented 6 years ago

I have a feeling this might give you an idea of something that could be causing this bug where only the top 4 rows are being lit up and the bottom two aren't. The affected keys selection from freestyle. When it is selected at the very bottom it actually selects the row with caps lock. That is the row where the lighting stops.

Thought I would leave the issues I come across in this thread as I have no idea if it is an issue with the MK750 or any other keyboard as well.

image

simon-wh commented 6 years ago

@MithicalM Temporary solution is to select a Mouse, which should make it return to normal. Currently trying to figure out why this is happening.

simon-wh commented 6 years ago

Looking into the issue, it turns out to be bigger than what I originally expected, however, if you set it to use a mouse in the layout it should be fine.

EDIT: Because I'm rewriting the section that causes this anyway, I might just leave it for now as there is a fine workaround available. I'll just make sure that it isn't an issue in the rewrite.

MithicalM commented 6 years ago

Yeah that is fine! Thanks! The only other big issue I have is the stuff constantly repeating in my log and create massive log files. [ERROR] 21:37:54: BitmapUtils.GetRegionColor() Exception: System.ArgumentException: Parameter is not valid. at System.Drawing.Bitmap.LockBits(Rectangle rect, ImageLockMode flags, PixelFormat format, BitmapData bitmapData) at System.Drawing.Bitmap.LockBits(Rectangle rect, ImageLockMode flags, PixelFormat format) at Aurora.Utils.BitmapUtils.GetRegionColor(Bitmap map, BitmapRectangle rectangle) in D:\Repos\Aurora\Project-Aurora\Project-Aurora\Utils\BitmapUtils.cs:line 23 [ERROR] 21:37:54: BitmapUtils.GetRegionColor() Exception: System.ArgumentException: Parameter is not valid. at System.Drawing.Bitmap.LockBits(Rectangle rect, ImageLockMode flags, PixelFormat format, BitmapData bitmapData) at System.Drawing.Bitmap.LockBits(Rectangle rect, ImageLockMode flags, PixelFormat format) at Aurora.Utils.BitmapUtils.GetRegionColor(Bitmap map, BitmapRectangle rectangle) in D:\Repos\Aurora\Project-Aurora\Project-Aurora\Utils\BitmapUtils.cs:line 23 [ERROR] 21:37:54: BitmapUtils.GetRegionColor() Exception: System.ArgumentException: Parameter is not valid. at System.Drawing.Bitmap.LockBits(Rectangle rect, ImageLockMode flags, PixelFormat format, BitmapData bitmapData) at System.Drawing.Bitmap.LockBits(Rectangle rect, ImageLockMode flags, PixelFormat format)

simon-wh commented 6 years ago

Yeah, I noticed that happening as well, if it is still happening with the mouse selected then switch off of the pro l layout, I think there is an issue with it that makes that happening.

simon-wh commented 6 years ago

@MithicalM With what I mentioned above does the main keyboard lighting work as expected on your keyboard?

MithicalM commented 6 years ago

@simon-wh Yeah it works fine now. The only issue is that the keys lighting is still misaligned by one key. So the "-, + and ENTER" keys on numpad have no lighting. Other than that I have had no issues at all.

BilbroSwaggins commented 6 years ago

Any update on this issue with some keys not lighting up? As of now using the latest build simon sent out, the F4, R SHIFT, ENTER, FN, ', ], =, UP ARROW, and the right most keys on the numpad(return, +, -, skip song) arent lighting up. Along with all the side lighting. Thanks for making this work so far!

MithicalM commented 6 years ago

@simon-wh Hey any update on this at all?

Junneh commented 6 years ago

I cant get it working at all with my new MK750 and 0.61dev4 Worked fine with masterkeys pro before. Doesnt seem to recognize the MK750 at all tho.

Edit: Working with the release.zip linked above, same numpad keys issue tho

Baralan commented 6 years ago

I cannot seem to get it to work at all whatsoever with any version. With some versions i just get no lighting on the keyboard. On the others the keyboard is connected, but it is still showing the original lighting, it also shows under device manager i have 3000-4000 ms.

Artis-Dev commented 6 years ago

Any progress to full suport for this keyboard?

simon-wh commented 6 years ago

@MithicalM @Moonart I have gotten frustrated enough trying to fix CM and MK750 related issues that I've bought one, it should be arriving today and hopefully today/tomorrow I'll be able to get it mostly fixed up. Hopefully with full support coming shortly after.

Edit: I've got the keyboard but the SDK is having some really weird behaviour (using the SDK example lights random keys when) so I'm not sure how soon I'll be able to get it fixed

simon-wh commented 6 years ago

@MithicalM @Moonart @BilbroSwaggins @Junneh @Baralan Have any of you tried using it while on the latest firmware?(V1.03.01) I got the keyboard and updated to that straight away and can't get the SDK to work (even just using the example) at all properly and I'm not sure if it is an issue with my particular keyboard or with the SDK not being updated for the firmware. Please let me know, as CM is being of no help in this matter.

Artis-Dev commented 6 years ago

Strange, in my case there are no update like this: http://prntscr.com/jedbz4

MithicalM commented 6 years ago

https://imgur.com/kDjOmNK mine says its got an update but when I click update it comes up with this window and I can't click on any of the buttons though. That's through the Cooler Master Portal BTW

MithicalM commented 6 years ago

image I just reinstalled the Cooler Master Portal and MK750 files by delting the files from the Program Files and deleting it from the Program and Files listing using CCleaner. I do have the option to update to the version you mentioned now @simon-wh

MithicalM commented 6 years ago

Okay so I have the same issue as you now @simon-wh it was fine on 1.01.23 but as soon as I updated to 1.03.01 I have just got random keys lighting up and it doesn't make any sense at all anymore. So I do not recommend anyone to update to V1.03.01 just yet.

simon-wh commented 6 years ago

@MithicalM Thanks for the confirmation, I'm glad that it is not just me experiencing this (unfortunate that you're now stuck with this too). Hopefully we'll get an update soon so I can get the MK750 support fixed, depending on how the SDK is updated it may require everyone to update to the latest firmware once it's fixed.

BilbroSwaggins commented 6 years ago

I still have not updated to 1.03.01, as I am still running 1.01.23 and everything is running perfectly fine. The only problems with Aurora is that certain keys arent lit up (as mentioned before). I am also getting what Moonart has with the update version being the same as what I am running. Cooler master seems very strange with this whole setup. I would recommend maybe talking to /u/Braumm (i think) on coolermaster's subreddit

simon-wh commented 6 years ago

@BilbroSwaggins The cooler master software is really strange, the way it works is not great. Also, I've tried that and haven't got any helpful response. Pretty disappointed in CM tbh, I really like the keyboard, but the software and support have a lot to be desired.

simon-wh commented 6 years ago

I got this reply from CM support, hopefully we'll get the update soon.

We have just received information that next week a new SDK will be released what supports also the MK750. We suggest to keep an eye on our website for more information ;) http://www.coolermaster.com/peripheral/keyboards/masterkeys-mk750/

MithicalM commented 6 years ago

I have an issue where Aurora won't open from any of the versions from this thread. It only launches if I launch the version from Aurora-v0.6.1-dev4. I am not sure if I missing something or not. I did reinstall windows which might have something to do with this.

Also when I went to install the Cooler Master MK750 drivers and I had an update for the keyboard firmware which could fix some of the bugs @simon-wh image

simon-wh commented 6 years ago

@MithicalM Strange, you got anything in your log files?

Also, thanks for letting me know, I'll see if that sorts out the sdk, I wouldn't have known otherwise as I use linux most of the time

EDIT: I've tried the latest firmware, now it just crashes when attempting to set specific keys when using the SDK example, not very happy with the lack of support from CM

MithicalM commented 6 years ago

2018-05-22 17.20.37.log This is what I am getting in the logs.

simon-wh commented 6 years ago

@MithicalM Could you try this build? It should at least get rid of the errors that are appearing