search

antonpup / Aurora

Unified lighting effects across multiple brands and various games.
http://www.project-aurora.com/
MIT License
1.83k stars 368 forks source link

Volume Overlay (Key Press layer conditional override) is delayed by several seconds. #1765

Open kathampy opened 5 years ago

kathampy commented 5 years ago

Expected Behaviour

Volume Overlay (Key Press layer conditional override) should respond immediately.

Actual Behaviour

It takes several seconds of repeatedly pressing VolumeUp / VolumeDown before they are recognized by the Key Press layer conditional override to enable the Volume Overlay layer.

Reproduction steps

Press the volume keys once, and the overlay does not trigger. Repeatedly press the volume keys for several seconds, and the overlay finally appears. While the overlay is enabled for 3 seconds, all volume changes are instantly recognized.

Frequency

Every time

Aurora Version

0.7.0

Previously an Issue?

No

Wibble199 commented 4 years ago

Does it behave like this if you were to use other keys?

In the meanwhile, you could also try replacing the two keydown conditions with a "Numeric change detector" and setting the watch value of that to be the LocalPCInfo\Volume game state.

kathampy commented 4 years ago

I'll test and report back. I created another solid fill layer below the volume overlay for a dimming effect, and assigned it the same volume key press override. The two layers activate at different times when pressing the volume keys, and sometimes only one activates.

kathampy commented 4 years ago

Does it behave like this if you were to use other keys?

In the meanwhile, you could also try replacing the two keydown conditions with a "Numeric change detector" and setting the watch value of that to be the LocalPCInfo\Volume game state.

Other keys respond instantly. The problem is only with the volume roller. I have a Logitech G810. Windows recognizes the volume change instantly.

The Numeric State Variable does not list any expressions in the drop down if it is a child of Number Change Detector. It only lists expressions if it's the top level element. I entered LocalPCInfo/SystemVolume manually into default.json as a workaround. It now detects instantly, but the lighting flickers only when pressing the volume keys as it has no retain duration.

Wibble199 commented 4 years ago

Yeah there's a known issue with the variables propogating down properly. Sometimes the vars reappear if you select a different property and then go back, but not always. :\

There should be a "True extender" (I think that's what it's called) which does what it's name suggests - extends the length of a true signal. If you put the change detector in one of these (you can use the copy and paste buttons so you don't have to repeat the JSON editing process), you should be able to make it stay on for a few seconds.