search

antonputra / tutorials

DevOps Tutorials
https://youtube.com/antonputra
MIT License
3.19k stars 2.5k forks source link

feat: Fix improper build command #268

Closed Uzaaft closed 2 months ago

Uzaaft commented 2 months ago

Your https://www.youtube.com/watch?v=VxW0ijXAfOs is not representative and should be taken down imo. Try again with the new dockerfile.

antonputra commented 2 months ago

Thanks for the PR! I'll merge and test in a couple of days. I don't want to mislead people right now.

Uzaaft commented 2 months ago

Thanks for the PR! I'll merge and test in a couple of days. I don't want to mislead people right now.

I get waiting for multiple PRs. But the last part doesnt check out. Your current video is already misleading people...

antonputra commented 2 months ago

@Uzaaft If I merge right now, people would assume I tested Zig with the flag you suggested.

antonputra commented 2 months ago

I'll collect all the tips I can, including pull requests, over the next 2 or 3 days and will release an updated video if there is a significant improvement, or a YouTube post with the results.

Uzaaft commented 2 months ago

I'll collect all the tips I can, including pull requests, over the next 2 or 3 days and will release an updated video if there is a significant improvement, or a YouTube post with the results.

Then you should add the currect git hash in your url as well so that people know exactly which revision the video is referring to.