search

antonputra / tutorials

DevOps Tutorials
https://youtube.com/antonputra
MIT License
3.19k stars 2.5k forks source link

Improve Nginx config in main branch #326

Closed melroy89 closed 3 weeks ago

melroy89 commented 3 weeks ago

Same as PR: https://github.com/antonputra/tutorials/pull/325

Please update your link in your video description..

antonputra commented 3 weeks ago

@melroy89 i specifically use git tag to reference exact commit that i used in the test https://github.com/antonputra/tutorials/tags

melroy89 commented 3 weeks ago

@melroy89 i specifically use git tag to reference exact commit that i used in the test https://github.com/antonputra/tutorials/tags

I see, but be aware that people (like me) might then also use this link as starting point of editing or improving. Hence GitHub will create a PR against that same branch.

antonputra commented 3 weeks ago

@melroy89 i used to provide a link to the main branch, but when I get a few PRs, it’s confusing which code was actually used in the test. however, I understand your point.