search

antonreshetov / vue-unicons

1000+ Pixel-perfect svg icons for your next project as Vue components
https://antonreshetov.github.io/vue-unicons/
MIT License
1k stars 56 forks source link

Unicons not packaged for distribution #34

Closed davestewart closed 4 years ago

davestewart commented 4 years ago

Hey @antonreshetov,

It seems that the package is not packaged for distribution:

image

Really, only the core files should be sent up to NPM (absolutely not node modules!) and the demo files should be managed separately (folder or repo).

I've got quite a bit of experience in packaging libs. Would you like some help?

Additionally, I think the main component could be rebuilt as a functional component with a render function, which would optimise it for speed. Could do this at the same time.

LMK.

antonreshetov commented 4 years ago

This library is called vue-unicons not unicons. Unicons is an dependency.

davestewart commented 4 years ago

OK, you both need to package your libs then:

image

antonreshetov commented 4 years ago

Maybe we shouldn't say that someone owes something? It's quite common for a library to have a source. Example - https://github.com/ElemeFE/element