antonvh / PUPRemote

GNU General Public License v3.0
2 stars 2 forks source link

Make MAX_PKT easily configurable as workaround for Pybricks #20

Closed marnovdm closed 8 months ago

marnovdm commented 8 months ago

After https://github.com/antonvh/PUPRemote/issues/19 I made a couple of small changes to make MAX_PKT easily configurable when instantiating the PUPRemote classes. I've tested it on my Mindstorms hub with LMS ESP32 and it seems to work as expected.

I also added a note to the README.md so other users can hopefully resolve this problem without having to raise a GitHub issue. I also added a reference to max_packet_size configuration in the 'Checksum error' text so it's easy to find. Please let me know if this is not up to standards or not the way to go about this.

Thanks for making these awesome projects!

EDIT: forgot to mention I removed the wrongly documented power option for PUPRemoteHub class from the docstring.