antonvh / PUPRemote

Communication protocol over LEGO PoweredUP (PUP) for hubs running Pybricks
GNU General Public License v3.0
6 stars 2 forks source link

Unnecessary callback? #6

Closed antonvh closed 1 year ago

antonvh commented 1 year ago

I think it can be more elegant without callback, since the callback is called from the process/heartbeat method. You could just as well pass a return value.

https://github.com/antonvh/PUPRemote/blob/bf360020e9d47dcc9672a2e383b8f1b2f04c8b3b/PUPRemote/pupremote.py#L101