antony-jr / AppImageUpdater

AppImage Updater for Humans built with QML/C++ with Qt5 :heart:.
GNU Lesser General Public License v3.0
40 stars 6 forks source link

AppImage not updating properly #16

Closed antony-jr closed 5 years ago

antony-jr commented 5 years ago

As seen in https://github.com/AppImage/AppImageUpdate/issues/128#issuecomment-519061086

CC: @luzpaz

Lets do any further discussions here to keep everything organized.

luzpaz commented 5 years ago

:+1:

antony-jr commented 5 years ago

So did you actually restart the application when you did the update?

luzpaz commented 5 years ago

hmm... I may have not

EDIT: will do that now

antony-jr commented 5 years ago

Because I think its a bug in the library such that when a error occurs all slots are just screwed, I have to fix that ASAP.

luzpaz commented 5 years ago

@antony-jr i just reran and it zipped through the download but now it hanging at 100% again (an aside: oddly it shows Updating 371 MiB of 363 Mib where before it showed 369 of 363 if you recall. Just thought I'd mention that)

antony-jr commented 5 years ago

But did the update succeed?

EDIT: any error dialog box?

luzpaz commented 5 years ago

no error but not sure how to see if succeeded. the log is similar to previous time.. just stops short of showing anything useful

antony-jr commented 5 years ago

Hmm... Looks like a serious one.

luzpaz commented 5 years ago

image
Here's what I see (same as before)

luzpaz commented 5 years ago

@antony-jr also note that pressing cancel will not affect anything. ~I need to ctrl+c in the CLI to kill the application~

EDIT: Actually that's not true. I just needed to close the dialog window.

antony-jr commented 5 years ago

Do you have qmake? dev-tools to compile Qt applications? If so then you can try compiling the example programs present in the library. https://github.com/antony-jr/AppImageUpdaterBridge and can test running the updater. Because this bug may be of AppImageUpdater and not the library.

 $ git clone https://github.com/antony-jr/AppImageUpdaterBridge
 $ cd AppImageUpdaterBridge
 $ cd examples/SimpleUpdateGUI
 $ mkdir build 
 $ cd build
 $ qmake ..
 $ make -j$(nproc)
 $ ./SimpleUpdateGUI [PATH TO APPIMAGE YOU WANT TO UPDATE]
luzpaz commented 5 years ago
$qmake --version
QMake version 3.1
Using Qt version 5.13.0 in /usr/lib

Is that OK ?

antony-jr commented 5 years ago

Yep that's all you need.

I assume you are using KDE?

luzpaz commented 5 years ago

Nope, Xfce

luzpaz commented 5 years ago

Ok, built SimpleUpdateGui and now retesting:
It got to 100% but is hanging again :cry:

luzpaz commented 5 years ago

...still hanging

antony-jr commented 5 years ago

If you have time please upload the AppImage you are trying to update to https://transfer.sh or any other services and share the link.

antony-jr commented 5 years ago

I can really use your mysterious AppImage to stress test the library in future.

luzpaz commented 5 years ago

uploading now to transfer.sh will post link when it's done.
FYI, i got an error back finally:
image

luzpaz commented 5 years ago

https://transfer.sh/rkaMF/FreeCAD_0.19-17499-Linux-Conda_Py3Qt5_glibc2.12-x86_64.AppImage

antony-jr commented 5 years ago

Thank you so much.

antony-jr commented 5 years ago

Screenshot_20190807_182958

Its so weird on my end the update finishes successfully. I think this issue occurs if you have slow internet connection????? What is your internet connection speed by the way.

Mine is ~2 Mega bytes per second(20 mega bit per second as given by ISP)

Anyways @luzpaz Thanks for your time. I will try my best to mimic your issue.

antony-jr commented 5 years ago

@luzpaz I got the error, Screenshot_20190807_183910

antony-jr commented 5 years ago

I will try implementing multiple range requests and try this again. Also I am gonna give some intervals between each request and response to make it easy on the server.

antony-jr commented 5 years ago

Hopefully this will be fixed... If not please reopen this. But this time I guess the program won't hang but gives a concise error message.