antony-jr / AppImageUpdater

AppImage Updater for Humans built with QML/C++ with Qt5 :heart:.
GNU Lesser General Public License v3.0
40 stars 6 forks source link

Updated file must also get the new name #5

Closed probonopd closed 6 years ago

probonopd commented 6 years ago
Downloads/AppImageUpdater-77e112e-x86_64.AppImage Downloads/Audacity-095ee91-x86_64.AppImage 

Intended result:

In addition to the original (old) file Downloads/Audacity-095ee91-x86_64.AppImage, there should be the updated (new) file Downloads/<FILENAME_OF_THE_NEW_FILE>.

Actual result:

result

me@host:~$ diff Downloads/Audacity-095ee91-x86_64.AppImage*
Binary files Downloads/Audacity-095ee91-x86_64.AppImage and Downloads/Audacity-095ee91-x86_64.AppImage.zs-old differ

Updated file must also get the new name, otherwise the file name is misleading.

antony-jr commented 6 years ago

hmm... no problem , but I think this will be a change in the Bridge.

probonopd commented 6 years ago

Wow, I am impressed, this looks like a straightforward change. Will there be a new AppimageUpdater to test?

antony-jr commented 6 years ago

Made very silly mistake so the continous integration is broken , Please wait.

antony-jr commented 6 years ago

@probonopd continous build of linuxdeployqt is broken (can't get the latest AppImages ? ) , thats why my continous build is also broken!

antony-jr commented 6 years ago

@probonopd I cannot find any assets on github , do I need to compile it my self ?

probonopd commented 6 years ago

@probonopd I cannot find any assets on github , do I need to compile it my self ?

Sorry, it's a bug, I am looking into it. Should be available again soon. https://github.com/AppImage/AppImageKit/issues/612#issuecomment-357441159

antony-jr commented 6 years ago

@probonopd Build Succeded , Check the new release. NOTE: The updater will automatically update itself but only the new version will have the update on renaming the files correctly. So test it out with other appimages.