search

antony-jr / QAppImageUpdate

Qt5 library and plugin for updating AppImages. :heart:
https://antony-jr.github.io/QAppImageUpdate
BSD 3-Clause "New" or "Revised" License
28 stars 13 forks source link

Install CMake config files #26

Closed kossebau closed 5 years ago

kossebau commented 5 years ago

What kind of change does this pull request introduce? (check at least one)

Describe your Pull Request: Not every system uses e.g. "lib/" as directory for libraries (could be also /lib64 or the Debian variant). CMake's default GNUInstallDirs macros helps here with that. Then, other projects using CMake and wanting to use this library might find it fancy to have CMake config files deployed for this library, so a simple find_package(AppImageUpdaterBridge) gets them ready to build and link against this lib, by just using the imported target AppImageUpdaterBridge.

Patches done after hint for need by @azubieta last Friday on irc channel #appimage (me being "frinring"), to prepare the building by packagers of Linux distributions of this and dependent software.

kossebau commented 5 years ago

I thought github had a feature one could do one review request on top of another existing review request. Did not find that now, so will simply add the second (and actually main commit) to this merge request as well...

antony-jr commented 5 years ago

Thank you for the PR! :+1:

azubieta commented 5 years ago

Thanks @kossebau !!

@antony-jr can you spin a micro release please? I need it to update the conan package.

antony-jr commented 5 years ago

@antony-jr can you spin a micro release please. I need it to update the conan package.

You want a new release(using github releases)? v1.1.3 from v1.1.2?

antony-jr commented 5 years ago

added a release tag(from github) v1.1.3? so now we just want to create a new branch on https://github.com/appimage-conan-community/conan-AppImageUpdaterBridge (named v1.1.3) and push the changes to trigger a conan build?

azubieta commented 5 years ago

The package tests must be also improved to ensure that the cmake module works. But don't worry I'll take care of it.

azubieta commented 5 years ago

for tracking purposes: https://github.com/appimage-conan-community/conan-AppImageUpdaterBridge/issues/2