antony / grails-oauth-scribe

Grails Oauth plugin using the Scribe library
23 stars 40 forks source link

Scribe Java 4.0.0 update #58

Closed gcrick closed 7 years ago

gcrick commented 7 years ago

Updated code to work with Scribe Java 4.0.0 and adjusted tests (all pass now). Updated plugin version to 4.0.0 due to breaking changes:

The changes were made somewhat blindly, without a deep understanding of OAuth - the minimum to make the tests pass and enable login with Facebook and Google. Some parts of the code are questionable. For example, OAuth2 does not use a RequestToken now, yet the plugin expects to find a RequestToken in the session in both cases and uses EMPTY_TOKEN for OAuth 2. Since Token is abstract in the new library, the value of EMPTY_TOKEN has been changed to an OAuth2AccessToken, which makes no sense.

antony commented 7 years ago

This is great @gcrick - thank you for your stellar efforts.

I'm intrigued that scribe have done a u-turn on the Oauth2 decision, after threatening to remove it.

I'll endeavour to get this merged in ASAP.