antonybudianto / angular-starter

:star: Gulp Angular Starter using TypeScript (Updated to 4.4.3)
https://antonybudianto.github.io/angular-starter/
MIT License
521 stars 147 forks source link

bugfix: tmp folder path regarding windows #188

Closed Michael-xxxx closed 7 years ago

Michael-xxxx commented 7 years ago

See issue: No file change on the screen, despite recompile (RaydonZhu comment) #187

edited fix #187

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 2554a9820fdad0fda8b80132e7456a18691d86a7 on Michael-xxxx:master into 386bae322ae61e0cbe467229cba9ece2b721ba51 on antonybudianto:master.

antonybudianto commented 7 years ago

@Michael-xxxx , nice, can you squash the commits into one?

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 4fd9b47b724099834e0846544c4dba8e8c194c7e on Michael-xxxx:master into 386bae322ae61e0cbe467229cba9ece2b721ba51 on antonybudianto:master.

antonybudianto commented 7 years ago

You can also create new PR to have 1 commit @Michael-xxxx

Michael-xxxx commented 7 years ago

I merge the two commits. I hope it is OK?

antonybudianto commented 7 years ago

@Michael-xxxx , no I mean, the commits should be one, currently it's 4 commits, can you open new PR with one commit? Thank you