antonycourtney / tad

A desktop application for viewing and analyzing tabular data
http://tadviewer.com
MIT License
3.18k stars 118 forks source link

linux: provide .png and/or .svg icon files for electron-builder to use #118

Open joebonrichie opened 6 years ago

joebonrichie commented 6 years ago

Currently tad only provides a .icn icon file, therefore electron-builder tries to call icns2png to convert it into a .png before packaging it on linux.

Tad has been accepted for inclusion within the Solus repository (https://dev.solus-project.com/T3893) my dilemma as a packager that is icns2png/libicns is not eligible for inclusion as it has not seen a release since 2012 and is DOA.

If you could provide either a high quality .png or .svg icon file for electron-builder to use on linux it would solve the problem. I maintain a fair amount of electron apps, the majority provide .png icon files.

Thanks in advance!

joebonrichie commented 6 years ago

Okay a didn't check probably you do provide a .png icon file, sorry for not checking! In that case on linux could you make electron-builder use that file instead of the .icn file.