add all available timestamp types to the column type map

antonycourtney / tad

A desktop application for viewing and analyzing tabular data

http://tadviewer.com

MIT License

3.18k stars 118 forks source link

add all available timestamp types to the column type map #237

Closed hamilton closed 1 year ago

hamilton commented 1 year ago

This PR adds all available timestamp types to the DuckDB dialect type map.

hamilton commented 1 year ago

In writing tests for this, I've discovered that the TIMESTAMP_XX functions do not uniformly convert to a Date object in DuckDB. Going to file an issue for this.

hamilton commented 1 year ago

@antonycourtney this PR is ready for review. The genesis of this PR was to fix something with tadviewer leveraging duckdb-wasm. But the updated test targets duckdb-node, which means we can't quite get test coverage for this issue until https://github.com/duckdb/duckdb-node/issues/13 closes.