search

antonycourtney / tad

A desktop application for viewing and analyzing tabular data
http://tadviewer.com
MIT License
3.18k stars 119 forks source link

chore(tadviewer): pin use-deep-compare pkg version #253

Closed dntosas closed 11 months ago

dntosas commented 11 months ago

The newly published package of use-deep-compare 1.2.0 seems to break tadviewer from building successfully. So in this commit, we are choring into pinning a specific pkg version.

Ref: https://www.npmjs.com/package/use-deep-compare/v/1.2.0

The next step should consider a proper path of upgrading this library and/or when needed.

hamilton commented 11 months ago

@antonycourtney I smoketested this against tadviewer w/

./tools/build-all.sh
cd packages/tad-app
npm start -- csv/bart-comp-all.csv

And saw no effect.

Not sure what's going on with the build errors here.