antonypro / QGoodWindow

QGoodWindow - border less window for Qt 5 and Qt 6
MIT License
516 stars 91 forks source link

Separate theme handling from frameless. #63

Open PaddleStroke opened 5 months ago

PaddleStroke commented 5 months ago

There is a single class QGoodWindow that handles everything. This is imo not ideal, because for example I'm trying to bring the frameless thing to an existing application where theme are already implemented. So that may generates conflicts.

Imo there should be 2 classes :

antonypro commented 5 months ago

@PaddleStroke:

The use of the themes provided by the library is not mandatory.

If you have your own theme and want to avoid QGoodWindow themes, simply don't call neither QGoodWindow::setAppDarkTheme() nor QGoodWindow::setAppLightTheme().

And I don't think the classes needs to be separated.

Thanks!