search

antouhou / rs-merkle

The most advanced Merkle tree library for Rust
MIT License
168 stars 45 forks source link

Enforce no_std support #21

Closed matthiasgoergens closed 1 year ago

matthiasgoergens commented 1 year ago

We tell github to build PRs with --no-default-features to ensure that building we no_std works.

This implements a suggestion brought up in the discussion around https://github.com/antouhou/rs-merkle/issues/19 and https://github.com/antouhou/rs-merkle/pull/18

Please review carefully: I tested the build command, but I couldn't locally test the full github workflow around it.

nickray commented 1 year ago

It would be good to test this by using actual no_std targets, similar to how RustCrypto does things: https://github.com/RustCrypto/hashes/blob/852feb9b91e2f8bb39cc3af42c461d0181d2def6/.github/workflows/sha2.yml#L20-L39

antouhou commented 1 year ago

I'll go ahead and merge it, and then add @nickray suggestion to the no-std check. Thank you!