Fix UI tests - Githubissues

antoyo / relm

Idiomatic, GTK+-based, GUI library, inspired by Elm, written in Rust

MIT License

2.44k stars 78 forks source link

Fix UI tests #100

Closed antoyo closed 6 years ago

antoyo commented 6 years ago

@Eijebong Here it is. What do you think?

I wonder if there's a better way to only generate code in test than having a feature. It looks very annoying to have a feature.

Issues:

[x] Need to create a new observer everytime. (Cannot reproduce, check last commit.)
[x] Bug when we have a #[cfg(test)] on a variant.
[x] Cannot use Foo::Bar in observer_wait!.

antoyo commented 6 years ago

@Eijebong I've removed the feature which was actually useless, indeed. Also, I updated the test to show how to access the model. Do you have enough for your needs?

Eijebong commented 6 years ago

That failure is legit (also I have a Component in my test window so right now I can't even try this :/)

antoyo commented 6 years ago

@Eijebong I added an Observer abstraction and macros to simplify their usage that will probably be very useful for your use case. Let me know what you think of this abstraction.