search

antoyo / relm

Idiomatic, GTK+-based, GUI library, inspired by Elm, written in Rust
MIT License
2.43k stars 78 forks source link

Remove g_object_new_with_properties #160

Closed jonas-schievink closed 5 years ago

jonas-schievink commented 5 years ago

It's not used anywhere, and glib::object::Object::new now has the same capabilities.

antoyo commented 5 years ago

I don't remember why, but I had planned to use it there. But it seems using Object::new would be even better. Do you want to update this code as well to use Object::new in this pull request as well? That would be really appreciated. If not, we can merge as is. Thanks.

jonas-schievink commented 5 years ago

I tried looking into that, but unfortunately the test suite doesn't work on my system (probably due to an outdated enigo dependency) so it's a bit difficult to verify that it worked.

jonas-schievink commented 5 years ago

@antoyo Hi! Any update on this?

antoyo commented 5 years ago

Sorry for the delay.