search

antoyo / relm

Idiomatic, GTK+-based, GUI library, inspired by Elm, written in Rust
MIT License
2.41k stars 79 forks source link

7GUI examples #282

Closed Schmiddiii closed 2 years ago

Schmiddiii commented 3 years ago

I have implemented the tasks of 7GUI in relm. These implementations could probably still be improved, but are working. I have not implemented every minor detail of the task (e.g. Editing a cell with right click instead of double click in the spreadsheet example), but in the React/MobX/Typescript version of the 7GUIs creator, such details might also be incorrect (e.g. Editing a cell with a single instead of a double click).

I have tried documenting my code, mainly in the first examples, but these probably still have incorrect spelling or grammar and should be corrected.

The only minor problem I still have is the directory structure. As I have put all tasks in a 7gui folder, these examples cannot be executed using cargo run --example in the relm-examples folder. They must be executed using cargo run in the folder of the example.

antoyo commented 3 years ago

Thanks! Could you please add the building of these examples and the execution of the tests (when there are tests) to the CI?

It'll take some time for me to review all this.

antoyo commented 3 years ago

Sorry for the long delay.

That will probably require a few changes after #291 is merged.

Schmiddiii commented 3 years ago

No problem.

Sadly I cannot work on this for a while, it will have to wait a while longer unless someone else wants to improve the code.

Schmiddiii commented 2 years ago

I think I now fixed all your reviews. I am not sure what needs to be fixed with the pull request you mentioned. Do only the versions in Cargo.toml need to be updated or some code?

Schmiddiii commented 2 years ago

I have now updated every gtk, glib, gio, ... version I used to ^0.14.0. This should hopefully make my examples compilable on the current master.

One problem I faced is override_background_color, which I used in the flightbooker example, seems to be deprecated. The new way to do this seems to be using CSS. I have no idea how to use CSS so I temporarily just kept the background color.

antoyo commented 2 years ago

Thanks a lot for your work!

Schmiddiii commented 2 years ago

Glad to help. I forgot to mention that this probably closes #183.