search

antoyo / relm

Idiomatic, GTK+-based, GUI library, inspired by Elm, written in Rust
MIT License
2.41k stars 79 forks source link

Generate `glib::object::Object::new` instead of unsafe code #304

Closed msrd0 closed 1 year ago

msrd0 commented 1 year ago

This removes all unsafe code that was previously being generated by the proc macro. Also simplifies the code a bit.

antoyo commented 1 year ago

Thanks for your contribution!

The CI now fails with some clippy warnings.

Can you please add the following at the crate root to silence those warnings?

#![allow(clippy::uninlined-format-args)]
msrd0 commented 1 year ago

Should be fixed now

antoyo commented 1 year ago

I guess you'll need to add allow(unknown_lints) as well since it seems the clippy lint is not on stable yet.

msrd0 commented 1 year ago

It looks like that didn't help. Maybe it would be sufficient to run clippy only on one Rust version?

antoyo commented 1 year ago

It seems like unknown_lints should come before the unknown lint in the list.

msrd0 commented 1 year ago

Interesting, I didn't know the order had any effect

antoyo commented 1 year ago

Thanks!