antoyo / relm

Idiomatic, GTK+-based, GUI library, inspired by Elm, written in Rust
MIT License
2.44k stars 78 forks source link

Remove the "old" loging, as mentioned in #97 #98

Closed zzeroo closed 6 years ago

zzeroo commented 6 years ago

@antoyo to be honest. I have not looked at the new relm error story yet. Is there anything else I can do here?

antoyo commented 6 years ago

Could you please remove anything related to logging, like the crates env_logger and log? Thanks for your contribution!

zzeroo commented 6 years ago

@all sorry for the noise I'm tired ><

@antoyo There is only one log crate usage in relm-state. But this looks good for me.

antoyo commented 6 years ago

I'll take a look at this error. It looks similar to the one we had after merging PR #104.

Eijebong commented 6 years ago

@antoyo I have a patch, I'll open a PR

antoyo commented 6 years ago

@zzeroo Please rebase against master (I've just merged @Eijebong PR).

antoyo commented 6 years ago

Thank you for your contribution.