search

antrancs / maeve

Maeve, a PWA Apple Music web player with Last.fm support. Built with Vue & Typescript
https://maevemusic.app/
GNU Affero General Public License v3.0
228 stars 25 forks source link

The "Now Playing" screen isn't updated when the music is from iCloud Music Library #12

Closed igor-makarov closed 5 years ago

igor-makarov commented 5 years ago

Steps to reproduce:

  1. Enable iCloud Music Library.
  2. Add an album that Apple Music doesn't recognize.
  3. Play it in Maeve.

Expected result: "Now Playing" gets updated with current music.
Actual result: "Now Playing" stays with whatever was playing before. If nothing was playing, the bottom "Now Playing" view is not visible at all. Playlist and song position get updated correctly but the title and image are not.

igor-makarov commented 5 years ago

My guess is something to do with it not having album artwork?

antrancs commented 5 years ago

Can you give me the link to the album that does not have an artwork as an example?

And I'm not sure I understand the steps to reproduce, let me clarify it:

  1. Play an album NOT from the Library.
  2. Then add a different album to the library.
  3. Play the album I just added

The bug is the title & image in the Now Playing bar is not updated.

Is that correct?

igor-makarov commented 5 years ago

Let me explain. I have some music that I own in mp3 files. You add the files to iTunes on a computer, and then enable iCloud Music Library, a service that existed before AM and was merged into it.

Once enabled, your files become available on all AM-enabled devices as if they were AM albums.
If the files have artwork attached, it will be displayed.

I've tried and the bug reproduces both with albums that have artwork and those without. The defining factor seems to be that they are from my music and not from AM catalog.
As you can see here, there are very few albums of British band Camel available. I have many more, and the bug occurs when I try to play them.

The bug is that the title and image in these cases isn't updated. If it's the first one to be played, the view doesn't show up at all.

antrancs commented 5 years ago

Okay, thanks for the details. I'll look into it.

igor-makarov commented 5 years ago

I've just played an album that's from my iCloud Music Library and the bug hasn't occured!
Did you do any work on this or did the issue go away because of Apple?

antrancs commented 5 years ago

Apple has fixed it. It wasn't supported at first. But now it's working fine 😁

Still waiting for the Radio Station support though.

igor-makarov commented 5 years ago

Awesome! Very nice.