support nsh encap and decap

antrea-io / libOpenflow

OpenFlow Go library

Apache License 2.0

9 stars 18 forks source link

support nsh encap and decap #25

Closed zhenglinan closed 1 year ago

zhenglinan commented 2 years ago

support nsh encap and decap @tnqn

Signed-off-by: zhenglinan zhenglinan101@163.com

tnqn commented 2 years ago

@zhenglinan thanks for the PR. @wenyingd could you take a look?

wenyingd commented 2 years ago

I have another question: are the new actions only for nsh packets, or also for ethernet? If they are only suitable for nsh packets, it is better to change names more concrete, otherwise, it is confusing when calling "encap(ethernet)"

wenyingd commented 2 years ago

Please pay attention on the DCO and test/golint errors.

Update: Please add unit test on your new code, e.g., you can test the message Marshal and Unmarshal in the case, so that we could avoid runtime issues.