search

antrea-io / libOpenflow

OpenFlow Go library
Apache License 2.0
9 stars 18 forks source link

Added timer to the stream outbound function in case ovs stops responding. #31

Open ashish-varma opened 1 year ago

ashish-varma commented 1 year ago

Fixed naming of some of the variables to more appropriate names.

wenyingd commented 1 year ago

The code looks good to me, I just want to confirm if any existing API can be used in the net.Conn to control timeout in Write action

Having an offline discussion with @ashish-varma, no better solution is found. Would you give some suggestions @tnqn @antoninbas

antoninbas commented 1 year ago

The code looks good to me, I just want to confirm if any existing API can be used in the net.Conn to control timeout in Write action

Having an offline discussion with @ashish-varma, no better solution is found. Would you give some suggestions @tnqn @antoninbas

I had the same question as @wenyingd, and I don't see an answer here yet. Why can't we use SetWriteDeadline?

ashish-varma commented 1 year ago

The code looks good to me, I just want to confirm if any existing API can be used in the net.Conn to control timeout in Write action

Having an offline discussion with @ashish-varma, no better solution is found. Would you give some suggestions @tnqn @antoninbas

I had the same question as @wenyingd, and I don't see an answer here yet. Why can't we use SetWriteDeadline?

It make more sense to use SetWriteDeadline. I am testing the code with this and update the commit. Thanks for the suggestion.

wenyingd commented 1 year ago

@antoninbas @tnqn Do you have other comments on this change?