antrea-io / nephe

Antrea-managed security policies in the public cloud
Apache License 2.0
9 stars 9 forks source link

Avoid crashing nephe if CRD is not present #273

Closed reachjainrahul closed 1 year ago

reachjainrahul commented 1 year ago

Description

CR controller tries to watch for CRs upon start. If the CRD definitions is not added by then, it use to restart the pod.

Changes

Added a routine to check for existence of CRDs before starting CR controller. It will loop for 1 hour with max backoff of 30 sec. After that nephe will be restarted.

reachjainrahul commented 1 year ago

Does it make more sense to put the crd.go under k8s directory?

Sure.. we can put under k8s.. and move tags to new dir.. will make the change

shenmo3 commented 1 year ago

Does it make more sense to put the crd.go under k8s directory?

Sure.. we can put under k8s.. and move tags to new dir.. will make the change

I was thinking crd is also a part of k8s right, and having multiple directories each with just one file is a bit ugly? Just different styles I think, no need to change.

reachjainrahul commented 1 year ago

/nephe-test-e2e-kind, /nephe-test-e2e-agentless-upgrade,

reachjainrahul commented 1 year ago

/nephe-test-e2e-kind,/nephe-test-e2e-agentless-upgrade

reachjainrahul commented 1 year ago

/nephe-test-e2e-kind

reachjainrahul commented 1 year ago

/nephe-test-e2e-aws