search

antrikshmisri / Github-Automation

Github automation with clean frontend
6 stars 7 forks source link

Updating Readme #7

Open Aniket-508 opened 2 years ago

Aniket-508 commented 2 years ago

In the steps for installation, it is mentioned to install node modules as npm install and then to start the development server as yarn start which will give error as npm generates package lock file whereas yarn generated yarn lock. So either change the npm install to yarn or instead change yarn start to npm start

Aniket-508 commented 2 years ago

@antrikshmisri

ssurbhi09 commented 2 years ago

Can you assign me?

ssurbhi09 commented 2 years ago

Done please check and also please add SWOC tag!

ssurbhi09 commented 2 years ago

@Aniket-508 done please check

Aniket-508 commented 2 years ago

@ssurbhi09 Hey, I actually am not the admin of this project. I just raised this issue as I thought it was a minor bug in readme. You can reach out to @antrikshmisri, he is the admin actually.

ssurbhi09 commented 2 years ago

@antrikshmisri aur please check my pr!

antrikshmisri commented 2 years ago

Hey @Aniket-508, this is weird, can you share the stack trace because starting the server with yarn start after installation with npm install shouldn't error out as far as I know. It should only error out if you further install something with yarn using `yarn add XYZ. Although, I think it is good to update the documentation so as to be consistent with the commands.

antrikshmisri commented 2 years ago

Hey @ssurbhi09,

@antrikshmisri aur please check my pr!

Done please check and also please add SWOC tag!

Hey @ssurbhi09, thanks for the PR. I will take a look as soon as possible.